Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: ui/gl/gl_image.h

Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing braces. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gl/gl.gyp ('k') | ui/gl/gl_image.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GL_GL_IMAGE_H_ 5 #ifndef UI_GL_GL_IMAGE_H_
6 #define UI_GL_GL_IMAGE_H_ 6 #define UI_GL_GL_IMAGE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 gfx::OverlayTransform transform, 67 gfx::OverlayTransform transform,
68 const gfx::Rect& bounds_rect, 68 const gfx::Rect& bounds_rect,
69 const gfx::RectF& crop_rect) = 0; 69 const gfx::RectF& crop_rect) = 0;
70 70
71 // Dumps information about the memory backing the GLImage to a dump named 71 // Dumps information about the memory backing the GLImage to a dump named
72 // |dump_name|. 72 // |dump_name|.
73 virtual void OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd, 73 virtual void OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd,
74 uint64_t process_tracing_id, 74 uint64_t process_tracing_id,
75 const std::string& dump_name) = 0; 75 const std::string& dump_name) = 0;
76 76
77 // If this returns true, then the command buffer client has requested a
78 // CHROMIUM image with internalformat GL_RGB, but the platform only supports
79 // GL_RGBA. The client is responsible for implementing appropriate
80 // workarounds. The only support that the command buffer provides is format
81 // validation during calls to copyTexImage2D and copySubTexImage2D.
82 //
83 // This is a workaround that is not intended to become a permanent part of the
84 // GLImage API. Theoretically, when Apple fixes their drivers, this can be
85 // removed. https://crbug.com/581777#c36
86 virtual bool EmulatingRGB() const;
87
77 protected: 88 protected:
78 virtual ~GLImage() {} 89 virtual ~GLImage() {}
79 90
80 private: 91 private:
81 friend class base::RefCounted<GLImage>; 92 friend class base::RefCounted<GLImage>;
82 93
83 DISALLOW_COPY_AND_ASSIGN(GLImage); 94 DISALLOW_COPY_AND_ASSIGN(GLImage);
84 }; 95 };
85 96
86 } // namespace gl 97 } // namespace gl
87 98
88 #endif // UI_GL_GL_IMAGE_H_ 99 #endif // UI_GL_GL_IMAGE_H_
OLDNEW
« no previous file with comments | « ui/gl/gl.gyp ('k') | ui/gl/gl_image.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698