Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 1870483002: S390: [generators] Decouple generator resume from fullcodegen. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [generators] Decouple generator resume from fullcodegen. Port 974721c66131d208571b8759a1caadf7f995c54c Original commit message: Introduce a ResumeGeneratorTrampoline, which does the actual stack state reconstruction (currently always restores a fullcodegen frame), and introduce appropriate TurboFan builtins for %GeneratorPrototype%.next, %GeneratorPrototype%.return and %GeneratorPrototype%.throw based on this native builtin. Also unify the flooding in case of step-in to always work based on JSFunction and remove the special casing for JSGeneratorObject. R=bmeurer@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG=chromium:513471 LOG=n Committed: https://crrev.com/41a9298524f8c21bd898ee57df3ce708b09c1d37 Cr-Commit-Position: refs/heads/master@{#35316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -111 lines) Patch
M src/full-codegen/s390/full-codegen-s390.cc View 3 chunks +10 lines, -111 lines 0 comments Download
M src/s390/builtins-s390.cc View 1 chunk +125 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-06 21:47:15 UTC) #1
MTBrandyberry
lgtm
4 years, 8 months ago (2016-04-06 21:51:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870483002/1
4 years, 8 months ago (2016-04-06 21:52:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 22:12:16 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 22:12:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41a9298524f8c21bd898ee57df3ce708b09c1d37
Cr-Commit-Position: refs/heads/master@{#35316}

Powered by Google App Engine
This is Rietveld 408576698