Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1870473002: Empty overrides file for GN on Mac (Closed)

Created:
4 years, 8 months ago by fbarchard1
Modified:
4 years, 8 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : use same overrides as webrtc #

Patch Set 3 : update doc to show linux/mac and Official #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
A build_overrides/build.gni View 1 1 chunk +15 lines, -0 lines 0 comments Download
M docs/getting_started.md View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
fbarchard1
tested locally on OSX gn gen out/Debug ninja -C out/Debug
4 years, 8 months ago (2016-04-06 21:40:58 UTC) #1
kjellander_chromium
lgtm
4 years, 8 months ago (2016-04-07 07:06:17 UTC) #2
fbarchard1
4 years, 8 months ago (2016-04-07 21:39:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8c8294f09be6ed3f36137e7a8e80157fe2805adc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698