Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1870443003: [Chromecast] Enable browser media tests to work on internal builds (Closed)

Created:
4 years, 8 months ago by halliwell
Modified:
4 years, 8 months ago
Reviewers:
derekjchow1, maclellant
CC:
chromium-reviews, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Enable browser media tests to work on internal builds Browser tests that do media playback have never worked on internal builds (they are disabled there) because we block media playback until an application moves to foreground. The test page never reaches this state because it is managed outside ApplicationManager. With this change, starting a test page can be delegated to internal code and handled through ApplicationManager. This allows the test to reach foreground status and play media. BUG=internal b/27192870 Committed: https://crrev.com/f2dcda891387f1513626ebdc1397fc0bda6adf38 Cr-Commit-Position: refs/heads/master@{#388549}

Patch Set 1 #

Patch Set 2 : Simplified helper API #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -55 lines) Patch
M chromecast/browser/BUILD.gn View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chromecast/browser/test/chromecast_browser_test.h View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M chromecast/browser/test/chromecast_browser_test.cc View 2 chunks +5 lines, -31 lines 0 comments Download
A chromecast/browser/test/chromecast_browser_test_helper.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A chromecast/browser/test/chromecast_browser_test_helper_default.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
M chromecast/browser/test/chromecast_shell_browser_test.cc View 1 2 5 chunks +12 lines, -13 lines 0 comments Download
M chromecast/chromecast_tests.gypi View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
halliwell
Internal CL coming also ...
4 years, 8 months ago (2016-04-07 01:38:05 UTC) #3
derekjchow1
lgtm % some discussion on the internal CL.
4 years, 8 months ago (2016-04-07 20:12:12 UTC) #4
halliwell
On 2016/04/07 20:12:12, derekjchow1 wrote: > lgtm % some discussion on the internal CL. Simplified ...
4 years, 8 months ago (2016-04-20 04:27:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870443003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870443003/40001
4 years, 8 months ago (2016-04-20 18:15:39 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-20 19:32:52 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:25 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f2dcda891387f1513626ebdc1397fc0bda6adf38
Cr-Commit-Position: refs/heads/master@{#388549}

Powered by Google App Engine
This is Rietveld 408576698