Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1870443002: Serialize invNormRotation in SkLightingShader. (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 8 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Serialize invNormRotation in SkLightingShader. This fixes a serialize-8888 / 8888 GM mismatch. This requires a picture bump so we know not to bother trying to read the invNormRotation vector from older .SKPs. Any chance no one's ever made one? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1870443002 Just bumping the picture version. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/0576aa9c0722bba358a27f80cc134ea2cd4ca2c9

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -63 lines) Patch
M include/core/SkPicture.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkLightingShader.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dm_flags.json View 1 2 15 chunks +0 lines, -60 lines 0 comments Download
M tools/dm_flags.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
mtklein_C
4 years, 8 months ago (2016-04-06 18:43:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870443002/1
4 years, 8 months ago (2016-04-06 18:43:39 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 19:14:05 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870443002/20001
4 years, 8 months ago (2016-04-06 19:56:25 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 20:08:58 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870443002/40001
4 years, 8 months ago (2016-04-07 12:46:16 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 12:56:47 UTC) #15
robertphillips
lgtm
4 years, 8 months ago (2016-04-08 19:07:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870443002/40001
4 years, 8 months ago (2016-04-08 19:08:55 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 19:19:53 UTC) #22
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0576aa9c0722bba358a27f80cc134ea2cd4ca2c9

Powered by Google App Engine
This is Rietveld 408576698