Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 187043004: cc: Remove impl_transform_is_unknown argument from OcclusionTracker. (Closed)

Created:
6 years, 9 months ago by danakj
Modified:
6 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Visibility:
Public.

Description

cc: Remove impl_transform_is_unknown argument from OcclusionTracker. This argument is just used for an early out. Instead don't call the method at all when it is true. Depends on: https://codereview.chromium.org/183563003/ R=enne BUG=344962 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255199

Patch Set 1 #

Patch Set 2 : occlusionparams2: perftest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -112 lines) Patch
M cc/layers/tiled_layer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M cc/trees/occlusion_tracker.h View 1 chunk +4 lines, -7 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 1 4 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 5 chunks +31 lines, -74 lines 0 comments Download
M cc/trees/quad_culler.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
danakj
6 years, 9 months ago (2014-03-04 22:59:26 UTC) #1
danakj
6 years, 9 months ago (2014-03-05 16:47:01 UTC) #2
enne (OOO)
lgtm. Sorry to make you ping me to get this reviewed.
6 years, 9 months ago (2014-03-05 18:12:20 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-05 18:13:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/187043004/1
6 years, 9 months ago (2014-03-05 18:15:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 18:34:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-05 18:34:22 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-05 18:39:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/187043004/1
6 years, 9 months ago (2014-03-05 18:41:02 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 19:55:34 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=120900
6 years, 9 months ago (2014-03-05 19:55:34 UTC) #11
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-05 19:56:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/187043004/40001
6 years, 9 months ago (2014-03-05 19:57:03 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 20:13:52 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-05 20:13:52 UTC) #15
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 9 months ago (2014-03-05 20:15:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/187043004/40001
6 years, 9 months ago (2014-03-05 20:20:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/187043004/40001
6 years, 9 months ago (2014-03-05 23:59:21 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 01:19:01 UTC) #19
Message was sent while issue was closed.
Change committed as 255199

Powered by Google App Engine
This is Rietveld 408576698