Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187043003: Fixes crashes related to reusing guest mode profiles and/or user manager. (Closed)

Created:
6 years, 9 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 9 months ago
Reviewers:
noms (inactive), sky
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Fixes crashes related to reusing guest mode profiles and/or user manager. BUG=345614, 347822, 346311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255320

Patch Set 1 #

Patch Set 2 : fix mac tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Monica, Please take a look. Thanks.
6 years, 9 months ago (2014-03-05 17:22:38 UTC) #1
noms (inactive)
lgtm
6 years, 9 months ago (2014-03-05 18:17:23 UTC) #2
Roger Tawa OOO till Jul 10th
Hi Scott, Can you please do an owner review? Thanks.
6 years, 9 months ago (2014-03-05 18:21:39 UTC) #3
sky
testing_profile_manager LGTM
6 years, 9 months ago (2014-03-05 21:20:48 UTC) #4
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 9 months ago (2014-03-05 21:30:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/187043003/20001
6 years, 9 months ago (2014-03-05 21:33:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 22:44:01 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=81932
6 years, 9 months ago (2014-03-05 22:44:02 UTC) #8
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 9 months ago (2014-03-06 01:17:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/187043003/20001
6 years, 9 months ago (2014-03-06 01:20:54 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 02:19:29 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275968
6 years, 9 months ago (2014-03-06 02:19:30 UTC) #12
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 9 months ago (2014-03-06 02:43:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/187043003/20001
6 years, 9 months ago (2014-03-06 03:07:52 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 03:35:33 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=276049
6 years, 9 months ago (2014-03-06 03:35:33 UTC) #16
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 9 months ago (2014-03-06 04:03:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/187043003/20001
6 years, 9 months ago (2014-03-06 04:04:59 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 13:01:16 UTC) #19
Message was sent while issue was closed. 
Change committed as 255320

Powered by Google App Engine
This is Rietveld 408576698