mash: Make sure the app-manifests for chrome gets built.

mash: Make sure the app-manifests for chrome gets built.

BUG=594419, 601983
Committed: https://crrev.com/789f26c9d398df3f48dc39541f3a8238a96fad4b
Cr-Commit-Position: refs/heads/master@{#386528}

[sadrul, 2016-04-09 15:37:41]

sadrul@chromium.org changed reviewers:
+ rockot@chromium.org, sky@chromium.org

[sadrul, 2016-04-09 15:37:41]

The manifest files were moved/refactored in crrev.com/385823, but the new
manifests for chrome was never actually built. So this adds that back. (with
this fix, if you do a clobber build, then things break, e.g. exe:chrome can no
longer connect to mojo:mus).

rockot@ for review. sky@ for owner

[sadrul, 2016-04-09 15:38:16]

On 2016/04/09 15:37:41, sadrul wrote:
> The manifest files were moved/refactored in crrev.com/385823, but the new
> manifests for chrome was never actually built. So this adds that back. (with

*without

> this fix, if you do a clobber build, then things break, e.g. exe:chrome can no
> longer connect to mojo:mus).
> 
> rockot@ for review. sky@ for owner

[sadrul, 2016-04-09 15:38:39]

Description was changed from

==========
mash: Make sure the app-manifests for chrome gets built.

BUG=594419
==========

to

==========
mash: Make sure the app-manifests for chrome gets built.

BUG=594419, 601983
==========

[Ken Rockot(use gerrit already), 2016-04-11 14:48:28]

Hmm. I specifically removed the dependency from chrome/browser because
chrome/browser itself doesn't normally depend on these manifests being built.

Could you instead move this into the clause within chrome_initial which
conditionally includes the chrome/app/mash dependency in deps? i.e.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/BUILD.gn&l=213

[Ken Rockot(use gerrit already), 2016-04-11 15:07:19]

thanks! lgtm

[sadrul, 2016-04-11 21:08:43]

sky: ping

[sky, 2016-04-11 23:45:53]

LGTM

[sadrul, 2016-04-12 00:06:02]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-04-12 00:06:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870393002/20001

[commit-bot: I haz the power, 2016-04-12 00:14:06]

Description was changed from

==========
mash: Make sure the app-manifests for chrome gets built.

BUG=594419, 601983
==========

to

==========
mash: Make sure the app-manifests for chrome gets built.

BUG=594419, 601983
==========

[commit-bot: I haz the power, 2016-04-12 00:14:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-12 00:15:04]

Description was changed from

==========
mash: Make sure the app-manifests for chrome gets built.

BUG=594419, 601983
==========

to

==========
mash: Make sure the app-manifests for chrome gets built.

BUG=594419, 601983

Committed: https://crrev.com/789f26c9d398df3f48dc39541f3a8238a96fad4b
Cr-Commit-Position: refs/heads/master@{#386528}
==========

[commit-bot: I haz the power, 2016-04-12 00:15:05]

Patchset 2 (id:??) landed as
https://crrev.com/789f26c9d398df3f48dc39541f3a8238a96fad4b
Cr-Commit-Position: refs/heads/master@{#386528}