runtime/vm/code_descriptors_test.cc - Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_descriptors_test.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review feedback. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/code_descriptors_test.cc

diff --git a/runtime/vm/code_descriptors_test.cc b/runtime/vm/code_descriptors_test.cc

index 5f8bb1d0651a891dc2ed47c9e6c2bc8e3467bdf3..3cc1ef9ce43e92a7ba5ad8471993dd90d11f8592 100644

--- a/runtime/vm/code_descriptors_test.cc

+++ b/runtime/vm/code_descriptors_test.cc

@@ -221,7 +221,7 @@ TEST_CASE(StackmapGC) {

const Library& lib = Library::Handle(Library::LookupLibrary(name));

EXPECT(!lib.IsNull());

Class& cls = Class::Handle(

- lib.LookupClass(String::Handle(Symbols::New("A"))));

+ lib.LookupClass(String::Handle(Symbols::New(thread, "A"))));

EXPECT(!cls.IsNull());

// Now compile the two functions 'A.foo' and 'A.moo'

« no previous file with comments | « runtime/vm/class_finalizer_test.cc ('k') | runtime/vm/code_generator.cc » ('j') | no next file with comments »