runtime/vm/ast_printer_test.cc - Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/ast_printer_test.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review feedback. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/ast_printer_test.cc

diff --git a/runtime/vm/ast_printer_test.cc b/runtime/vm/ast_printer_test.cc

index 588d7023f96619e1eb4548dcae28887680d08e68..5b774e8f5992e68f61e2807366fbd9f7d7728136 100644

--- a/runtime/vm/ast_printer_test.cc

+++ b/runtime/vm/ast_printer_test.cc

@@ -18,7 +18,7 @@ TEST_CASE(AstPrinter) {

const TokenPosition kPos = TokenPosition::kNoSource;

LocalVariable* v =

new LocalVariable(kPos,

- String::ZoneHandle(Symbols::New("wurscht")),

+ String::ZoneHandle(Symbols::New(thread, "wurscht")),

Type::ZoneHandle(Type::DynamicType()));

v->set_index(5);

LoadLocalNode* ll = new LoadLocalNode(kPos, v);

« no previous file with comments | « runtime/vm/ast.cc ('k') | runtime/vm/ast_test.cc » ('j') | no next file with comments »