runtime/vm/snapshot_test.cc - Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/snapshot_test.cc

Issue 1870343002: - Refactor Symbol allocation to expect a thread parameter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/snapshot_test.cc

diff --git a/runtime/vm/snapshot_test.cc b/runtime/vm/snapshot_test.cc

index 26dccc88441f892f0851e6f79842bd6407e99957..573addf1b36868ff64fcda061aecaea30a9f3d79 100644

--- a/runtime/vm/snapshot_test.cc

+++ b/runtime/vm/snapshot_test.cc

@@ -943,7 +943,7 @@ TEST_CASE(SerializeScript) {

Script& script = Script::Handle(Script::New(url,

source,

RawScript::kScriptTag));

- const String& lib_url = String::Handle(Symbols::New("TestLib"));

+ const String& lib_url = String::Handle(Symbols::New(thread, "TestLib"));

Library& lib = Library::Handle(Library::New(lib_url));

lib.Register();

EXPECT(CompilerTest::TestCompileScript(lib, script));