[Mac][Material Design] Change toolbar buttons to 24x24 from 28x28.

[Mac][Material Design] Change toolbar buttons to 24x24 from 28x28.

The Material Design spec called for 28x28 toolbar buttons that touched
each other. sgabriel@ revised the spec to specify 24x24 toolbar buttons
with 4 pts of horizontal padding between them. This cl makes that
change, and incidentally fixes a problem where it was no longer
possible to resize the location bar by dragging it from its right edge.

R=avi@chromium.org, sky@chromium.org
BUG=601967
Committed: https://crrev.com/ad7c8102d9803e02da41b96071c5d68931772bb3
Cr-Commit-Position: refs/heads/master@{#386404}

[shrike, 2016-04-09 00:50:16]

PTAL

avi@
  chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
  chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

sky@
  chrome/browser/ui/layout_constants.cc
  chrome/browser/ui/toolbar/toolbar_actions_bar.cc

[Avi (use Gerrit), 2016-04-09 02:18:24]

lgtm

[sky, 2016-04-11 15:13:02]

LGTM

https://codereview.chromium.org/1870333002/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/1870333002/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:51: return 24;
The conditional is the same, so move the ifdef inside the conditional, eg:
if (ui::MaterialDesignController::IsModeM...) {
#if defined
...
#else
#endif
}

[shrike, 2016-04-11 16:11:42]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-04-11 16:11:42]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1870333002/#ps20001
(title: "Fix conditional.")

[commit-bot: I haz the power, 2016-04-11 16:12:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870333002/20001

[commit-bot: I haz the power, 2016-04-11 16:54:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 16:55:18]

Description was changed from

==========
[Mac][Material Design] Change toolbar buttons to 24x24 from 28x28.

The Material Design spec called for 28x28 toolbar buttons that touched
each other. sgabriel@ revised the spec to specify 24x24 toolbar buttons
with 4 pts of horizontal padding between them. This cl makes that
change, and incidentally fixes a problem where it was no longer
possible to resize the location bar by dragging it from its right edge.

R=avi@chromium.org, sky@chromium.org
BUG=601967
==========

to

==========
[Mac][Material Design] Change toolbar buttons to 24x24 from 28x28.

The Material Design spec called for 28x28 toolbar buttons that touched
each other. sgabriel@ revised the spec to specify 24x24 toolbar buttons
with 4 pts of horizontal padding between them. This cl makes that
change, and incidentally fixes a problem where it was no longer
possible to resize the location bar by dragging it from its right edge.

R=avi@chromium.org, sky@chromium.org
BUG=601967

Committed: https://crrev.com/ad7c8102d9803e02da41b96071c5d68931772bb3
Cr-Commit-Position: refs/heads/master@{#386404}
==========

[commit-bot: I haz the power, 2016-04-11 16:55:19]

Patchset 2 (id:??) landed as
https://crrev.com/ad7c8102d9803e02da41b96071c5d68931772bb3
Cr-Commit-Position: refs/heads/master@{#386404}