Use corerct conversions for DataView accessors.

test/mjsunit/harmony/dataview-accessors.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 276 matching lines @@
 }
 
 function TestSetters() {
   runIntegerTestCases(false, initialArray, 0, 16);
   runFloatTestCases(false);
 
   runIntegerTestCases(false, initialArray, 3, 2);
   runFloatTestCases(false, 7);
 
   runNegativeIndexTests(false);
-
 }
 
 TestGetters();
 TestSetters();
 
+function CheckOutOfRange(typename, value, expected) {

[titzer, 2013/07/12 16:37:02]

Mmmm...jsiness. Could we have a version of this test that doesn't use computed
properties? I know its more verbose, but can result in different hydrogen code.

[Dmitry Lomov (no reviews), 2013/07/12 18:22:45]

Done.

+  var view = new DataView(new ArrayBuffer(100));
+  assertSame(undefined, view["set" + typename](0, value));
+  assertSame(expected, view["get" + typename](0));
+  assertSame(undefined, view["set" + typename](0, value, true));
+  assertSame(expected, view["get" + typename](0, true));
+}
+
+function TestOutOfRange() {
+  CheckOutOfRange("Int8", 0x80,   -0x80);
+  CheckOutOfRange("Int8", 0x1000, 0);
+  CheckOutOfRange("Int8", -0x81,  0x7F);
+
+  CheckOutOfRange("Uint8", 0x100,  0);
+  CheckOutOfRange("Uint8", 0x1000, 0);
+  CheckOutOfRange("Uint8", -0x80,  0x80);
+  CheckOutOfRange("Uint8", -1,     0xFF);
+  CheckOutOfRange("Uint8", -0xFF,  1);
+
+  CheckOutOfRange("Int16", 0x8000,  -0x8000);
+  CheckOutOfRange("Int16", 0x10000, 0);
+  CheckOutOfRange("Int16", -0x8001, 0x7FFF);
+
+  CheckOutOfRange("Uint16", 0x10000,  0);
+  CheckOutOfRange("Uint16", 0x100000, 0);
+  CheckOutOfRange("Uint16", -0x8000,  0x8000);
+  CheckOutOfRange("Uint16", -1,       0xFFFF);
+  CheckOutOfRange("Uint16", -0xFFFF,  1);
+
+  CheckOutOfRange("Int32", 0x80000000,  -0x80000000);
+  CheckOutOfRange("Int32", 0x100000000, 0);
+  CheckOutOfRange("Int32", -0x80000001, 0x7FFFFFFF);
+
+  CheckOutOfRange("Uint32", 0x100000000,  0);
+  CheckOutOfRange("Uint32", 0x1000000000, 0);
+  CheckOutOfRange("Uint32", -0x80000000,  0x80000000);
+  CheckOutOfRange("Uint32", -1,           0xFFFFFFFF);
+  CheckOutOfRange("Uint32", -0xFFFFFFFF,  1);
+}
+
+TestOutOfRange();
+
 function TestGeneralAccessors() {
   var a = new DataView(new ArrayBuffer(256));
   function CheckAccessor(name) {
     var f = a[name];
     assertThrows(function() { f(); }, TypeError);
     f.call(a, 0, 0); // should not throw
     assertThrows(function() { f.call({}, 0, 0); }, TypeError);
     assertThrows(function() { f.call(a); }, TypeError);
   }
   CheckAccessor("getUint8");
   CheckAccessor("setUint8");
   CheckAccessor("getInt8");
   CheckAccessor("setInt8");
   CheckAccessor("getUint16");
   CheckAccessor("setUint16");
   CheckAccessor("getInt16");
   CheckAccessor("setInt16");
   CheckAccessor("getUint32");
   CheckAccessor("setUint32");
   CheckAccessor("getInt32");
   CheckAccessor("setInt32");
   CheckAccessor("getFloat32");
   CheckAccessor("setFloat32");
   CheckAccessor("getFloat64");
   CheckAccessor("setFloat64");
 }
 
 TestGeneralAccessors();