[Courgette] Sort section headers by sh_offset in ELF flows.

[Courgette] Sort section headers by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

This does not affect unittests. All test ELF data have "properly" sorted
sections, except elf-32-high-bss. And for this file, the offending .bss
section has sh_type=SHT_NOBITS, so DisassemblerElf32::ParseFile()
would ignore it.

BUG=601948
Committed: https://crrev.com/8cffb28385dffb40c2c773b5b4c0730a533cd025
Cr-Commit-Position: refs/heads/master@{#386306}

[huangs, 2016-04-08 22:40:15]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 22:40:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870293002/1

[huangs, 2016-04-08 22:56:22]

Description was changed from

==========
[Courgette] Sort section headeres by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

BUG=601948
==========

to

==========
[Courgette] Sort section headeres by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

This does not affect unittests. All test ELF data have "properly" sorted
sections, except elf-32-high-bss. And for this file, the offending .bss
section has sh_type=SHT_NOBITS, so DisassemblerElf32::ParseFile()
would ignore it.

BUG=601948
==========

[huangs, 2016-04-08 22:56:22]

huangs@chromium.org changed reviewers:
+ wfh@chromium.org

[huangs, 2016-04-08 22:56:35]

Description was changed from

==========
[Courgette] Sort section headeres by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

This does not affect unittests. All test ELF data have "properly" sorted
sections, except elf-32-high-bss. And for this file, the offending .bss
section has sh_type=SHT_NOBITS, so DisassemblerElf32::ParseFile()
would ignore it.

BUG=601948
==========

to

==========
[Courgette] Sort section headers by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

This does not affect unittests. All test ELF data have "properly" sorted
sections, except elf-32-high-bss. And for this file, the offending .bss
section has sh_type=SHT_NOBITS, so DisassemblerElf32::ParseFile()
would ignore it.

BUG=601948
==========

[huangs, 2016-04-08 22:58:18]

M51 patch might be a bit bigger without this fix, but I don't think it's worth
rushing this.  PTAL.

[commit-bot: I haz the power, 2016-04-08 23:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 23:38:26]

Dry run: This issue passed the CQ dry run.

[Will Harris, 2016-04-09 19:35:57]

lgtm

[Will Harris, 2016-04-09 19:36:01]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2016-04-09 19:36:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870293002/1

[commit-bot: I haz the power, 2016-04-09 19:44:01]

Description was changed from

==========
[Courgette] Sort section headers by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

This does not affect unittests. All test ELF data have "properly" sorted
sections, except elf-32-high-bss. And for this file, the offending .bss
section has sh_type=SHT_NOBITS, so DisassemblerElf32::ParseFile()
would ignore it.

BUG=601948
==========

to

==========
[Courgette] Sort section headers by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

This does not affect unittests. All test ELF data have "properly" sorted
sections, except elf-32-high-bss. And for this file, the offending .bss
section has sh_type=SHT_NOBITS, so DisassemblerElf32::ParseFile()
would ignore it.

BUG=601948
==========

[commit-bot: I haz the power, 2016-04-09 19:44:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-09 19:45:16]

Description was changed from

==========
[Courgette] Sort section headers by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

This does not affect unittests. All test ELF data have "properly" sorted
sections, except elf-32-high-bss. And for this file, the offending .bss
section has sh_type=SHT_NOBITS, so DisassemblerElf32::ParseFile()
would ignore it.

BUG=601948
==========

to

==========
[Courgette] Sort section headers by sh_offset in ELF flows.

Courgette ELF flows assumes that sections are sorted by |sh_offset|, but
this assumption may flow. In particular, nacl_irt_x86_32.nexe breaks
this, and this impacts Windows x86 Chrome because the .nexe file is
included. Solution is to do sort sections so we process them in the
order in file offset order.

This does not affect unittests. All test ELF data have "properly" sorted
sections, except elf-32-high-bss. And for this file, the offending .bss
section has sh_type=SHT_NOBITS, so DisassemblerElf32::ParseFile()
would ignore it.

BUG=601948

Committed: https://crrev.com/8cffb28385dffb40c2c773b5b4c0730a533cd025
Cr-Commit-Position: refs/heads/master@{#386306}
==========

[commit-bot: I haz the power, 2016-04-09 19:45:17]

Patchset 1 (id:??) landed as
https://crrev.com/8cffb28385dffb40c2c773b5b4c0730a533cd025
Cr-Commit-Position: refs/heads/master@{#386306}