Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: ct/go/worker_scripts/run_chromium_perf/main.go

Issue 1870173002: [CT] Add desktop device when running run_benchmark (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ct/go/worker_scripts/fix_archives/main.go ('k') | ct/go/worker_scripts/run_chromium_perf_swarming/main.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ct/go/worker_scripts/run_chromium_perf/main.go
diff --git a/ct/go/worker_scripts/run_chromium_perf/main.go b/ct/go/worker_scripts/run_chromium_perf/main.go
index 8ceea37a4b6372b526069a98fdb427e6b0b24a83..6797cc3074a078a03d1809c1b05a3bb75b18fa8b 100644
--- a/ct/go/worker_scripts/run_chromium_perf/main.go
+++ b/ct/go/worker_scripts/run_chromium_perf/main.go
@@ -305,7 +305,7 @@ func runBenchmark(fileInfoName, pathToPagesets, pathToPyFiles, localOutputDir, c
// Need to capture output for all benchmarks.
outputDirArgValue := filepath.Join(localOutputDir, pagesetName)
args = append(args, "--output-dir="+outputDirArgValue)
- // Figure out which browser should be used.
+ // Figure out which browser and device should be used.
if *targetPlatform == util.PLATFORM_ANDROID {
if err := util.InstallChromeAPK(chromiumBuildName); err != nil {
return fmt.Errorf("Error while installing APK: %s", err)
@@ -313,12 +313,11 @@ func runBenchmark(fileInfoName, pathToPagesets, pathToPyFiles, localOutputDir, c
args = append(args, "--browser=android-chromium")
} else {
args = append(args, "--browser=exact", "--browser-executable="+chromiumBinary)
+ args = append(args, "--device=desktop")
}
// Split benchmark args if not empty and append to args.
if *benchmarkExtraArgs != "" {
- for _, benchmarkArg := range strings.Fields(*benchmarkExtraArgs) {
- args = append(args, benchmarkArg)
- }
+ args = append(args, strings.Fields(*benchmarkExtraArgs)...)
}
// Add the number of times to repeat.
args = append(args, fmt.Sprintf("--page-repeat=%d", *repeatBenchmark))
« no previous file with comments | « ct/go/worker_scripts/fix_archives/main.go ('k') | ct/go/worker_scripts/run_chromium_perf_swarming/main.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698