Issue 187017: Skip running layout tests in contained in 'script-tests' directories too....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187017: Skip running layout tests in contained in 'script-tests' directories too.... (Closed)

Created:
11 years, 3 months ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
eseidel, dglazkov, hamaji

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Skip running layout tests contained in 'script-tests' directories too. BUG=20908 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25344

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/tools/layout_tests/run_webkit_tests.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hamaji

Looks good! Thanks for doing this. Don't we need to revert the change for test_expectations.txt ...

11 years, 3 months ago (2009-09-02 23:44:48 UTC) #2

michaeln

> test_expectations.txt ? I can do that seperately... didn't want to do that while i'm ...

11 years, 3 months ago (2009-09-02 23:58:28 UTC) #3

hamaji

> I can do that seperately... didn't want to do that while i'm sheriffing so ...

11 years, 3 months ago (2009-09-02 23:59:31 UTC) #4

michaeln

I don't know the layout of the layout tests (ha) so well. Would it better ...

11 years, 3 months ago (2009-09-03 00:05:18 UTC) #5

eseidel

11 years, 3 months ago (2009-09-03 05:52:50 UTC) #6

script-tests should be treated exactly like resources and skipped entirely.
 Eventually we may run script-tests directly generating the actual tests
from the TEMPlATE.html on the fly.

On Thu, Sep 3, 2009 at 1:05 AM, <michaeln@chromium.org> wrote:

>
> I don't know the layout of the layout tests (ha) so well.
>
> Would it better to exclude files named 'TEMPLATE.html' in addition to or
> instead of skipping 'script-tests' directories?
>
> http://codereview.chromium.org/187017
>

Expand Messages | Collapse Messages