Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1870163004: [css-flexbox] slight improvements to mainSizeForPercentageResolution (Closed)

Created:
4 years, 8 months ago by cbiesinger
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] slight improvements to mainSizeForPercentageResolution We can skip a check if flexBasis has a percentage (see comment in patch). Also, reusing mainAxisLengthIsDefinite will be slightly more correct. R=leviw@chromium.org CC=dgrogran@chromium.org BUG=595361 Committed: https://crrev.com/37e278b6d096600cc1351a40aefd0e7a71601167 Cr-Commit-Position: refs/heads/master@{#386234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
cbiesinger
4 years, 8 months ago (2016-04-08 21:36:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870163004/1
4 years, 8 months ago (2016-04-08 21:36:34 UTC) #3
leviw_travelin_and_unemployed
Okay. LGTM.
4 years, 8 months ago (2016-04-08 22:25:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870163004/1
4 years, 8 months ago (2016-04-08 22:26:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 22:51:28 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 22:52:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37e278b6d096600cc1351a40aefd0e7a71601167
Cr-Commit-Position: refs/heads/master@{#386234}

Powered by Google App Engine
This is Rietveld 408576698