Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1870163002: aw: Expose setDrawGLFunctionDetachedCallback to AwContents (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Expose setDrawGLFunctionDetachedCallback to AwContents This is needed for generic Views to correctly support FullScreenView. This CL basically reverts r386036. BUG=597167 Committed: https://crrev.com/e30cdcefc38b4d8ba9cbe827328c9b8867cf2fec Cr-Commit-Position: refs/heads/master@{#386110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java View 2 chunks +5 lines, -3 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +8 lines, -3 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
boliu
4 years, 8 months ago (2016-04-08 16:49:37 UTC) #2
boliu
+sgurun to stamp
4 years, 8 months ago (2016-04-08 16:59:09 UTC) #4
sgurun-gerrit only
On 2016/04/08 16:59:09, boliu wrote: > +sgurun to stamp lgtm
4 years, 8 months ago (2016-04-08 17:00:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870163002/1
4 years, 8 months ago (2016-04-08 17:01:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 17:24:00 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 17:26:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e30cdcefc38b4d8ba9cbe827328c9b8867cf2fec
Cr-Commit-Position: refs/heads/master@{#386110}

Powered by Google App Engine
This is Rietveld 408576698