Make some GMs animate

Make some GMs animate
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1870133003

Committed: https://skia.googlesource.com/skia/+/651bb5fafe1edd723425dffd478dfa67b113da73

[robertphillips, 2016-04-08 16:46:15]

Description was changed from

==========
Make some GMs animate
==========

to

==========
Make some GMs animate
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-08 16:54:17]

Description was changed from

==========
Make some GMs animate
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make some GMs animate
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-08 16:54:17]

robertphillips@google.com changed reviewers:
+ jvanverth@google.com

[jvanverth1, 2016-04-08 19:10:56]

lgtm

lgtm + comment

https://codereview.chromium.org/1870133003/diff/20001/gm/dashcircle.cpp
File gm/dashcircle.cpp (right):

https://codereview.chromium.org/1870133003/diff/20001/gm/dashcircle.cpp#newco...
gm/dashcircle.cpp:97: fRotation = (fRotation + 2) % 360;
I suppose it's not a big deal, but the animation speed of this will vary
depending on the frame rate.

[robertphillips, 2016-04-08 20:14:58]

https://codereview.chromium.org/1870133003/diff/20001/gm/dashcircle.cpp
File gm/dashcircle.cpp (right):

https://codereview.chromium.org/1870133003/diff/20001/gm/dashcircle.cpp#newco...
gm/dashcircle.cpp:97: fRotation = (fRotation + 2) % 360;
On 2016/04/08 19:10:56, jvanverth1 wrote:
> I suppose it's not a big deal, but the animation speed of this will vary
> depending on the frame rate.

Doh - fixed.

[robertphillips, 2016-04-08 20:18:38]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 20:18:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870133003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870133003/40001

[commit-bot: I haz the power, 2016-04-08 20:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 20:33:01]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-08 20:34:11]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-08 20:34:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/1870133003/#ps40001
(title: "Actually use the timer")

[commit-bot: I haz the power, 2016-04-08 20:34:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870133003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870133003/40001

[commit-bot: I haz the power, 2016-04-08 20:35:16]

Description was changed from

==========
Make some GMs animate
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make some GMs animate
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/651bb5fafe1edd723425dffd478dfa67b113da73
==========

[commit-bot: I haz the power, 2016-04-08 20:35:17]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/651bb5fafe1edd723425dffd478dfa67b113da73

[edzyaani9093, 2016-04-10 08:44:02]

edzyaani9093@gmail.com changed reviewers:
+ edzyaani9093@gmail.com

[edzyaani9093, 2016-04-10 08:44:03]

lgtm