Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1870133002: Refactor serialization test files. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -584 lines) Patch
M tests/compiler/dart2js/serialization_analysis_test.dart View 2 chunks +1 line, -200 lines 0 comments Download
M tests/compiler/dart2js/serialization_impact_test.dart View 1 2 chunks +2 lines, -62 lines 0 comments Download
M tests/compiler/dart2js/serialization_model_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization_test.dart View 3 chunks +8 lines, -264 lines 0 comments Download
A + tests/compiler/dart2js/serialization_test_data.dart View 3 chunks +2 lines, -54 lines 0 comments Download
A tests/compiler/dart2js/serialization_test_helper.dart View 1 chunk +365 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
4 years, 8 months ago (2016-04-08 14:48:19 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 8 months ago (2016-04-08 16:19:26 UTC) #4
Johnni Winther
4 years, 8 months ago (2016-04-11 08:41:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
1f6c0dd14b28779258728e8005dca7fa0ae68dcb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698