Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 18701002: Remove deprecated heap profiler methods from V8 public API (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove deprecated heap profiler methods from V8 public API v8::HeapProfiler::FindHeapSnapshot was already deprecated when 3.19 branch was created (https://code.google.com/p/v8/source/browse/branches/3.19/include/v8-profiler.h). BUG=None R=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M include/v8-profiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap-profiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-profiler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap-snapshot-generator.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/heap-snapshot-generator.cc View 5 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 5 months ago (2013-07-04 14:04:41 UTC) #1
loislo
lgtm
7 years, 5 months ago (2013-07-04 14:12:38 UTC) #2
Yang
On 2013/07/04 14:12:38, loislo wrote: > lgtm LGTM.
7 years, 5 months ago (2013-07-04 15:02:30 UTC) #3
yurys
7 years, 5 months ago (2013-07-04 16:34:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15493 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698