Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3677)

Unified Diff: build/config/android/internal_rules.gni

Issue 1870073002: Properly set up classpath for Android Lint (and fix its stderr filter) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Skip --android-sdk-version for GYP build Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/lint.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index b94134c07cddeeff62877b278a089571b968db96..140bd4854f95e2a6af309beb7354259f139a070a 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -60,6 +60,7 @@ template("android_lint") {
rebase_path(_cache_dir, root_build_dir),
"--platform-xml-path",
rebase_path(_platform_xml_path, root_build_dir),
+ "--android-sdk-version=${android_sdk_version}",
"--depfile",
rebase_path(depfile, root_build_dir),
"--config-path",
@@ -92,8 +93,7 @@ template("android_lint") {
"--jar-path",
rebase_path(invoker.jar_path, root_build_dir),
"--java-files=$_rebased_java_files",
- "--classpath=['$rebased_android_sdk_jar']",
- "--classpath=@FileArg($_rebased_build_config:javac:interface_classpath)",
+ "--classpath=@FileArg($_rebased_build_config:javac:classpath)",
]
}
}
« no previous file with comments | « build/android/gyp/lint.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698