build/android/android_lint_cache.gyp - Issue 1870073002: Properly set up classpath for Android Lint (and fix its stderr filter)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/android_lint_cache.gyp

Issue 1870073002: Properly set up classpath for Android Lint (and fix its stderr filter) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Skip --android-sdk-version for GYP build Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/android_lint_cache.gyp

diff --git a/build/android/android_lint_cache.gyp b/build/android/android_lint_cache.gyp

index 8c5175de2e6c799ce4d61df31f7d24c55dc55760..72b9e9e0099c664616df14bc214681e5365d0290 100644

--- a/build/android/android_lint_cache.gyp

+++ b/build/android/android_lint_cache.gyp

@@ -34,6 +34,7 @@

'python', '<(DEPTH)/build/android/gyp/lint.py',

'--lint-path', '<(android_sdk_root)/tools/lint',

'--cache-dir', '<(PRODUCT_DIR)/android_lint_cache',

+ '--android-sdk-version=<(android_sdk_version)',

'--platform-xml-path', '<(platform_xml_path)',

'--manifest-path', '<(android_manifest_path)',

'--product-dir', '<(PRODUCT_DIR)',

« no previous file with comments | « no previous file | build/android/gyp/lint.py » ('j') | no next file with comments »