Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4281)

Unified Diff: build/android/lint_action.gypi

Issue 1870073002: Properly set up classpath for Android Lint (and fix its stderr filter) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/lint_action.gypi
diff --git a/build/android/lint_action.gypi b/build/android/lint_action.gypi
index 382666213da3b1ba8e4b0869a702dc4ee5a58f82..c0ce3b7a8cc8b22b2b4e743643f5df6b0dfd95f4 100644
--- a/build/android/lint_action.gypi
+++ b/build/android/lint_action.gypi
@@ -37,6 +37,7 @@
'--config-path=<(suppressions_file)',
'--processed-config-path=<(config_path)',
'--cache-dir', '<(PRODUCT_DIR)/android_lint_cache',
+ '--android-sdk-version=<(android_sdk_version)',
agrieve 2016/04/08 15:16:12 Since at the moment lint warnings fail GYP builds
mlopatkin 2016/04/08 16:55:16 We can make --android-sdk-version optional for now
'--platform-xml-path', '<(platform_xml_path)',
'--manifest-path=<(android_manifest_path)',
'--result-path=<(result_path)',

Powered by Google App Engine
This is Rietveld 408576698