Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

The few places these are called are better served by explicit
calls to CFX_ByteString() itself.  This helps make Byte and
Wide strings more similar.

Also prevents fx_string.h from having any knowledge of fx_basic.h's
ByteTextBuf class.

Committed: https://pdfium.googlesource.com/pdfium/+/f172290a8dc527cd8bc73b0d0ad59e78797968c1

[Tom Sepez, 2016-04-08 16:29:03]

Description was changed from

==========
Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

The few places these are called are better served by explicit
calss to CFX_ByteString() itself.  This helps make Byte and
Wide strings more similar.
==========

to

==========
Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

The few places these are called are better served by explicit
calss to CFX_ByteString() itself.  This helps make Byte and
Wide strings more similar.

Also prevents fx_string.h from having any knowledge of fx_basic.h's
ByteTextBuf class.
==========

[Tom Sepez, 2016-04-08 16:29:03]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-08 16:29:15]

Lei, quick review.

[Lei Zhang, 2016-04-08 19:03:43]

lgtm

"calss" typo in commit message.

[Tom Sepez, 2016-04-08 19:13:10]

Description was changed from

==========
Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

The few places these are called are better served by explicit
calss to CFX_ByteString() itself.  This helps make Byte and
Wide strings more similar.

Also prevents fx_string.h from having any knowledge of fx_basic.h's
ByteTextBuf class.
==========

to

==========
Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

The few places these are called are better served by explicit
calls to CFX_ByteString() itself.  This helps make Byte and
Wide strings more similar.

Also prevents fx_string.h from having any knowledge of fx_basic.h's
ByteTextBuf class.
==========

[Tom Sepez, 2016-04-08 19:13:22]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-08 19:13:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870043003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870043003/1

[commit-bot: I haz the power, 2016-04-08 19:13:57]

Description was changed from

==========
Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

The few places these are called are better served by explicit
calls to CFX_ByteString() itself.  This helps make Byte and
Wide strings more similar.

Also prevents fx_string.h from having any knowledge of fx_basic.h's
ByteTextBuf class.
==========

to

==========
Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf

The few places these are called are better served by explicit
calls to CFX_ByteString() itself.  This helps make Byte and
Wide strings more similar.

Also prevents fx_string.h from having any knowledge of fx_basic.h's
ByteTextBuf class.

Committed:
https://pdfium.googlesource.com/pdfium/+/f172290a8dc527cd8bc73b0d0ad59e787979...
==========

[commit-bot: I haz the power, 2016-04-08 19:13:58]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f172290a8dc527cd8bc73b0d0ad59e787979...