Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3644)

Unified Diff: chrome/browser/history/visit_database.cc

Issue 187004: Adding in memory log of history visit database. This... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/visit_log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/visit_database.cc
===================================================================
--- chrome/browser/history/visit_database.cc (revision 25036)
+++ chrome/browser/history/visit_database.cc (working copy)
@@ -8,6 +8,7 @@
#include <set>
#include "chrome/browser/history/visit_database.h"
+#include "chrome/browser/history/visit_log.h"
#include "chrome/browser/history/url_database.h"
#include "chrome/common/page_transition_types.h"
@@ -115,6 +116,7 @@
statement->bind_int64(3, visit->transition);
statement->bind_int64(4, visit->segment_id);
statement->bind_int64(5, visit->is_indexed);
+ AddEventToVisitLog(VisitLog::ADD_VISIT);
if (statement->step() != SQLITE_DONE)
return 0;
@@ -132,6 +134,7 @@
return;
update_chain->bind_int64(0, visit.referring_visit);
update_chain->bind_int64(1, visit.visit_id);
+ AddEventToVisitLog(VisitLog::UPDATE_VISIT);
update_chain->step();
// Now delete the actual visit.
@@ -140,6 +143,7 @@
if (!del.is_valid())
return;
del->bind_int64(0, visit.visit_id);
+ AddEventToVisitLog(VisitLog::DELETE_VISIT);
del->step();
}
@@ -150,6 +154,7 @@
return false;
statement->bind_int64(0, visit_id);
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
if (statement->step() != SQLITE_ROW)
return false;
@@ -172,6 +177,7 @@
statement->bind_int64(4, visit.segment_id);
statement->bind_int64(5, visit.is_indexed);
statement->bind_int64(6, visit.visit_id);
+ AddEventToVisitLog(VisitLog::UPDATE_VISIT);
return statement->step() == SQLITE_DONE;
}
@@ -187,6 +193,7 @@
return false;
statement->bind_int64(0, url_id);
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
FillVisitVector(*statement, visits);
return true;
}
@@ -210,6 +217,7 @@
statement->bind_int64(2,
max_results ? max_results : std::numeric_limits<int64>::max());
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
FillVisitVector(*statement, visits);
}
@@ -239,6 +247,7 @@
statement->bind_int64(4,
max_results ? max_results : std::numeric_limits<int64>::max());
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
FillVisitVector(*statement, visits);
}
@@ -271,6 +280,7 @@
statement->bind_int(5, PageTransition::MANUAL_SUBFRAME);
statement->bind_int(6, PageTransition::KEYWORD_GENERATED);
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
std::set<URLID> found_urls;
while (statement->step() == SQLITE_ROW) {
VisitRow visit;
@@ -301,6 +311,7 @@
return 0;
statement->bind_int64(0, url_id);
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
if (statement->step() != SQLITE_ROW)
return 0; // No visits for this URL.
@@ -329,6 +340,7 @@
statement->bind_int64(0, url_id);
statement->bind_int(1, max_results);
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
FillVisitVector(*statement, visits);
return true;
}
@@ -347,6 +359,7 @@
statement->bind_int64(0, from_visit);
statement->bind_int(1, PageTransition::IS_REDIRECT_MASK);
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
if (statement->step() != SQLITE_ROW)
return false; // No redirect from this visit.
if (to_visit)
@@ -373,6 +386,7 @@
"WHERE v.id = ?");
statement->bind_int64(0, row.referring_visit);
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
if (statement->step() != SQLITE_ROW)
return false;
@@ -413,6 +427,7 @@
statement->bind_string(0, host_query_min);
statement->bind_string(1, host_query_max);
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
if (statement->step() != SQLITE_ROW) {
// We've never been to this page before.
*count = 0;
@@ -427,6 +442,7 @@
bool VisitDatabase::GetStartDate(Time* first_visit) {
SQLITE_UNIQUE_STATEMENT(statement, GetStatementCache(),
"SELECT MIN(visit_time) FROM visits WHERE visit_time != 0");
+ AddEventToVisitLog(VisitLog::SELECT_VISIT);
if (!statement.is_valid() || statement->step() != SQLITE_ROW ||
statement->column_int64(0) == 0) {
*first_visit = Time::Now();
« no previous file with comments | « no previous file | chrome/browser/history/visit_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698