Adding in memory log of history visit database. This...

Adding in memory log of history visit database. This
log will be saved in crash dump (to be done in next
CL) to help debug the corruption in history thread.

TEST=Added unit test.
BUG=16591
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25276

[brettw, 2009-09-02 16:14:50]

http://codereview.chromium.org/187004/diff/7001/7003
File chrome/browser/history/visit_log.cc (right):

http://codereview.chromium.org/187004/diff/7001/7003#newcode46
Line 46: void InitVisitLog(VisitLog* vlog) {
It doesn't look like this is called anywhere. Did you forget?

http://codereview.chromium.org/187004/diff/7001/7004
File chrome/browser/history/visit_log.h (right):

http://codereview.chromium.org/187004/diff/7001/7004#newcode5
Line 5: #ifndef CHROME_BROWSER_HISTORY_VISIT_LOG_H__
Only use one underscore at the end of preprocessor guards.

http://codereview.chromium.org/187004/diff/7001/7004#newcode58
Line 58: }  // namespace history
Can you put an extra blank line before this?

[huanr, 2009-09-02 16:29:50]

http://codereview.chromium.org/187004/diff/7001/7003
File chrome/browser/history/visit_log.cc (right):

http://codereview.chromium.org/187004/diff/7001/7003#newcode46
Line 46: void InitVisitLog(VisitLog* vlog) {
Calling Init will be done in next change. To make sure VisitLog is in crash
dump, I intended to allocate it on the local stack at the early stage of thread
creation. That involves special treatment of history thread and may need some
discussion so I will do it in a separate CL.

On 2009/09/02 16:14:50, brettw wrote:
> It doesn't look like this is called anywhere. Did you forget?

http://codereview.chromium.org/187004/diff/7001/7004
File chrome/browser/history/visit_log.h (right):

http://codereview.chromium.org/187004/diff/7001/7004#newcode5
Line 5: #ifndef CHROME_BROWSER_HISTORY_VISIT_LOG_H__
On 2009/09/02 16:14:50, brettw wrote:
> Only use one underscore at the end of preprocessor guards.

Done.

http://codereview.chromium.org/187004/diff/7001/7004#newcode58
Line 58: }  // namespace history
On 2009/09/02 16:14:50, brettw wrote:
> Can you put an extra blank line before this?

Done.

[brettw, 2009-09-02 21:44:46]

I see, LGTM