Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: base/threading/platform_thread_internal_posix.cc

Issue 1870033002: Fix NiceValueToThreadPriority failing on an unknown nice value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a comment about exclusion of OSX/iOS. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/platform_thread_internal_posix.h" 5 #include "base/threading/platform_thread_internal_posix.h"
6 6
7 #include "base/containers/adapters.h"
7 #include "base/logging.h" 8 #include "base/logging.h"
8 9
9 namespace base { 10 namespace base {
10 11
11 namespace internal { 12 namespace internal {
12 13
13 int ThreadPriorityToNiceValue(ThreadPriority priority) { 14 int ThreadPriorityToNiceValue(ThreadPriority priority) {
14 for (const ThreadPriorityToNiceValuePair& pair : 15 for (const auto& pair : kThreadPriorityToNiceValueMap) {
15 kThreadPriorityToNiceValueMap) {
16 if (pair.priority == priority) 16 if (pair.priority == priority)
17 return pair.nice_value; 17 return pair.nice_value;
18 } 18 }
19 NOTREACHED() << "Unknown ThreadPriority"; 19 NOTREACHED() << "Unknown ThreadPriority";
20 return 0; 20 return 0;
21 } 21 }
22 22
23 ThreadPriority NiceValueToThreadPriority(int nice_value) { 23 ThreadPriority NiceValueToThreadPriority(int nice_value) {
24 for (const ThreadPriorityToNiceValuePair& pair : 24 // Try to find a priority that best describes |nice_value|. If there isn't
25 kThreadPriorityToNiceValueMap) { 25 // an exact match, this method returns the closest priority whose nice value
26 if (pair.nice_value == nice_value) 26 // is higher (lower priority) than |nice_value|.
27 for (const auto& pair : Reversed(kThreadPriorityToNiceValueMap)) {
28 if (pair.nice_value >= nice_value)
27 return pair.priority; 29 return pair.priority;
28 } 30 }
29 NOTREACHED() << "Unknown nice value"; 31
30 return ThreadPriority::NORMAL; 32 // Reaching here means |nice_value| is more than any of the defined
33 // priorities. The lowest priority is suitable in this case.
34 return ThreadPriority::BACKGROUND;
31 } 35 }
32 36
33 } // namespace internal 37 } // namespace internal
34 38
35 } // namespace base 39 } // namespace base
OLDNEW
« no previous file with comments | « base/threading/platform_thread_internal_posix.h ('k') | base/threading/platform_thread_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698