chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.h - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.h

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/incident_receiver.h ('k') | chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.h b/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.h

index 46de6fe06807edf4eb890b39ca8a8915d250cad9..d2254b552c4cd6378ddde540d2f95b56e1bbdc1a 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.h

+++ b/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader.h

@@ -5,8 +5,9 @@

#ifndef CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_INCIDENT_REPORT_UPLOADER_H_

#define CHROME_BROWSER_SAFE_BROWSING_INCIDENT_REPORTING_INCIDENT_REPORT_UPLOADER_H_

+#include <memory>

#include "base/callback.h"

-#include "base/memory/scoped_ptr.h"

namespace safe_browsing {

@@ -31,7 +32,7 @@ class IncidentReportUploader {

// A callback run by the uploader upon success or failure. The first argument

// indicates the result of the upload, while the second contains the response

// received, if any.

- typedef base::Callback<void(Result, scoped_ptr<ClientIncidentResponse>)>

+ typedef base::Callback<void(Result, std::unique_ptr<ClientIncidentResponse>)>

OnResultCallback;

virtual ~IncidentReportUploader();