chrome/browser/safe_browsing/protocol_parser.cc - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc ('K') | « chrome/browser/safe_browsing/protocol_parser.h ('k') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('j') | chrome/browser/safe_browsing/ui_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/protocol_parser.cc

diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc

index fd2a3f3b0a981c51bf11db2c67fc150817b98031..16561e875aa46678af7dfca12eb2637520d3ec38 100644

--- a/chrome/browser/safe_browsing/protocol_parser.cc

+++ b/chrome/browser/safe_browsing/protocol_parser.cc

@@ -392,7 +392,7 @@ bool ParseUpdate(const char* chunk_data,

// CHUNKDATA = Encoded ChunkData protocol message

bool ParseChunk(const char* data,

size_t length,

- std::vector<scoped_ptr<SBChunkData>>* chunks) {

+ std::vector<std::unique_ptr<SBChunkData>>* chunks) {

BufferReader reader(data, length);

while (!reader.empty()) {

@@ -404,7 +404,7 @@ bool ParseChunk(const char* data,

if (!reader.RefData(&p, l))

return false;

- scoped_ptr<SBChunkData> chunk(new SBChunkData());

+ std::unique_ptr<SBChunkData> chunk(new SBChunkData());

if (!chunk->ParseFrom(reinterpret_cast<const unsigned char*>(p), l))

return false;