chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/platform_state_store.h ('k') | chrome/browser/safe_browsing/incident_reporting/platform_state_store_unittest.cc » ('j') | chrome/browser/safe_browsing/ui_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc b/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

index 59aeda4649b310adc53b8d2093dc4a07392ce3d0..54319ea4b082c73e0de8c8face57ee1007a68721 100644

--- a/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

@@ -127,9 +127,10 @@ void RestoreFromProtobuf(

#endif // USE_PLATFORM_STATE_STORE

-scoped_ptr<base::DictionaryValue> Load(Profile* profile) {

+std::unique_ptr<base::DictionaryValue> Load(Profile* profile) {

#if defined(USE_PLATFORM_STATE_STORE)

- scoped_ptr<base::DictionaryValue> value_dict(new base::DictionaryValue());

+ std::unique_ptr<base::DictionaryValue> value_dict(

+ new base::DictionaryValue());

std::string data;

PlatformStateStoreLoadResult result = ReadStoreData(profile, &data);

if (result == PlatformStateStoreLoadResult::SUCCESS)