Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1869983002: Remove IOSurfaceLayer (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IOSurfaceLayer This was only used by NPAPI. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3a5e993ac76ffb3bfbb359f3dbd9516574e982e7 Cr-Commit-Position: refs/heads/master@{#386450}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -511 lines) Patch
M cc/BUILD.gn View 1 2 chunks +0 lines, -5 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D cc/layers/io_surface_layer.h View 1 1 chunk +0 lines, -40 lines 0 comments Download
D cc/layers/io_surface_layer.cc View 1 1 chunk +0 lines, -53 lines 0 comments Download
D cc/layers/io_surface_layer_impl.h View 1 1 chunk +0 lines, -55 lines 0 comments Download
D cc/layers/io_surface_layer_impl.cc View 1 1 chunk +0 lines, -108 lines 0 comments Download
D cc/layers/io_surface_layer_impl_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 3 chunks +0 lines, -164 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
piman
4 years, 8 months ago (2016-04-08 02:41:09 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869983002/1
4 years, 8 months ago (2016-04-08 03:45:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 04:38:29 UTC) #7
danakj
Oh wow cool LGTM https://codereview.chromium.org/1869983002/diff/1/cc/trees/layer_tree_host_unittest.cc File cc/trees/layer_tree_host_unittest.cc (left): https://codereview.chromium.org/1869983002/diff/1/cc/trees/layer_tree_host_unittest.cc#oldcode2284 cc/trees/layer_tree_host_unittest.cc:2284: test_capabilities_.gpu.iosurface = true; Do either ...
4 years, 8 months ago (2016-04-08 20:45:12 UTC) #8
danakj
https://code.google.com/p/chromium/codesearch#chromium/src/cc/quads/io_surface_draw_quad.h too?
4 years, 8 months ago (2016-04-08 20:45:32 UTC) #9
piman
https://codereview.chromium.org/1869983002/diff/1/cc/trees/layer_tree_host_unittest.cc File cc/trees/layer_tree_host_unittest.cc (left): https://codereview.chromium.org/1869983002/diff/1/cc/trees/layer_tree_host_unittest.cc#oldcode2284 cc/trees/layer_tree_host_unittest.cc:2284: test_capabilities_.gpu.iosurface = true; On 2016/04/08 20:45:12, danakj wrote: > ...
4 years, 8 months ago (2016-04-11 18:17:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869983002/1
4 years, 8 months ago (2016-04-11 18:18:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/17124) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-11 18:21:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869983002/20001
4 years, 8 months ago (2016-04-11 18:36:46 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 20:05:16 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:06:48 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a5e993ac76ffb3bfbb359f3dbd9516574e982e7
Cr-Commit-Position: refs/heads/master@{#386450}

Powered by Google App Engine
This is Rietveld 408576698