Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: runtime/vm/safepoint.h

Issue 1869933002: Do not block for safepoint when transitioning from generated code to VM, otherwise the result may n… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: sync Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/safepoint.h
diff --git a/runtime/vm/safepoint.h b/runtime/vm/safepoint.h
index 1c13a872f379371d8ea07cf0f64274b3df16b917..947742512ddad6f6991d01c183f526de79217968 100644
--- a/runtime/vm/safepoint.h
+++ b/runtime/vm/safepoint.h
@@ -309,12 +309,6 @@ class TransitionToGenerated : public TransitionSafepointState {
} else {
ASSERT(execution_state_ == Thread::kThreadInVM);
thread()->set_execution_state(Thread::kThreadInVM);
- // Fast check to see if a safepoint is requested or not.
- // We do the more expensive operation of blocking the thread
- // only if a safepoint is requested.
- if (thread()->IsSafepointRequested()) {
- handler()->BlockForSafepoint(thread());
- }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698