Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1869933002: Do not block for safepoint when transitioning from generated code to VM, otherwise the result may n… (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not block for safepoint when transitioning from generated code to VM, otherwise the result may not be GC'd. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1e601fb467be46d1f5437bb7e08ec876ce52a811

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M runtime/vm/safepoint.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
srdjan
4 years, 8 months ago (2016-04-07 22:51:40 UTC) #2
siva
lgtm
4 years, 8 months ago (2016-04-07 22:54:17 UTC) #3
srdjan
Committed patchset #2 (id:20001) manually as 1e601fb467be46d1f5437bb7e08ec876ce52a811 (presubmit successful).
4 years, 8 months ago (2016-04-07 22:59:33 UTC) #5
Florian Schneider
4 years, 8 months ago (2016-04-07 23:58:06 UTC) #7
Message was sent while issue was closed.
Nice!

It fixes https://github.com/dart-lang/sdk/issues/26211

Powered by Google App Engine
This is Rietveld 408576698