Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 18699002: Remove #include "heap-snapshot-generator-inl.h" from v8.h (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove #include "heap-snapshot-generator-inl.h" from v8.h This reduces number of dependent .cc files to 9 (was whole v8). BUG=None R=loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 5 months ago (2013-07-04 14:00:57 UTC) #1
loislo
lgtm
7 years, 5 months ago (2013-07-04 14:13:05 UTC) #2
Yang
On 2013/07/04 14:13:05, loislo wrote: > lgtm LGTM.
7 years, 5 months ago (2013-07-04 15:00:06 UTC) #3
yurys
7 years, 5 months ago (2013-07-04 16:32:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698