Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: chrome/browser/views/shell_dialogs.cc

Issue 18699: Fix a bug when saving web pages that have a period in their title (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/download/save_package.cc ('k') | chrome/common/win_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/shell_dialogs.h" 5 #include "chrome/browser/shell_dialogs.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <Commdlg.h> 8 #include <Commdlg.h>
9 #include <shlobj.h> 9 #include <shlobj.h>
10 #include <atlbase.h> 10 #include <atlbase.h>
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 const std::wstring& default_extension, 297 const std::wstring& default_extension,
298 RunState run_state, 298 RunState run_state,
299 void* params) { 299 void* params) {
300 std::wstring path = default_path; 300 std::wstring path = default_path;
301 bool success = false; 301 bool success = false;
302 if (type == SELECT_FOLDER) { 302 if (type == SELECT_FOLDER) {
303 success = RunSelectFolderDialog(title, run_state.owner, &path); 303 success = RunSelectFolderDialog(title, run_state.owner, &path);
304 } else if (type == SELECT_SAVEAS_FILE) { 304 } else if (type == SELECT_SAVEAS_FILE) {
305 unsigned index = 0; 305 unsigned index = 0;
306 success = win_util::SaveFileAsWithFilter(run_state.owner, default_path, 306 success = win_util::SaveFileAsWithFilter(run_state.owner, default_path,
307 filter, default_extension, &index, &path); 307 filter, default_extension, false, &index, &path);
308 DisableOwner(run_state.owner); 308 DisableOwner(run_state.owner);
309 } else if (type == SELECT_OPEN_FILE) { 309 } else if (type == SELECT_OPEN_FILE) {
310 success = RunOpenFileDialog(title, filter, run_state.owner, &path); 310 success = RunOpenFileDialog(title, filter, run_state.owner, &path);
311 } else if (type == SELECT_OPEN_MULTI_FILE) { 311 } else if (type == SELECT_OPEN_MULTI_FILE) {
312 std::vector<std::wstring> paths; 312 std::vector<std::wstring> paths;
313 if (RunOpenMultiFileDialog(title, filter, run_state.owner, &paths)) { 313 if (RunOpenMultiFileDialog(title, filter, run_state.owner, &paths)) {
314 ui_loop_->PostTask(FROM_HERE, NewRunnableMethod(this, 314 ui_loop_->PostTask(FROM_HERE, NewRunnableMethod(this,
315 &SelectFileDialogImpl::MultiFilesSelected, paths, params, run_state)); 315 &SelectFileDialogImpl::MultiFilesSelected, paths, params, run_state));
316 return; 316 return;
317 } 317 }
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 void SelectFontDialogImpl::FontNotSelected(void* params, RunState run_state) { 659 void SelectFontDialogImpl::FontNotSelected(void* params, RunState run_state) {
660 if (listener_) 660 if (listener_)
661 listener_->FontSelectionCanceled(params); 661 listener_->FontSelectionCanceled(params);
662 EndRun(run_state); 662 EndRun(run_state);
663 } 663 }
664 664
665 // static 665 // static
666 SelectFontDialog* SelectFontDialog::Create(Listener* listener) { 666 SelectFontDialog* SelectFontDialog::Create(Listener* listener) {
667 return new SelectFontDialogImpl(listener); 667 return new SelectFontDialogImpl(listener);
668 } 668 }
OLDNEW
« no previous file with comments | « chrome/browser/download/save_package.cc ('k') | chrome/common/win_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698