Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 1869833003: 🎾 Ensure wrapper scripts are marked as runtime_deps. (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure wrapper scripts are marked as runtime_deps. BUG=589318 Committed: https://crrev.com/186e41912ca83cb820a2ebf4521457bbfc30d542 Cr-Commit-Position: refs/heads/master@{#385828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/04/07 18:17:18, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org
4 years, 8 months ago (2016-04-07 18:17:24 UTC) #3
jbudorick
lgtm
4 years, 8 months ago (2016-04-07 18:20:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869833003/1
4 years, 8 months ago (2016-04-07 18:29:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 19:12:44 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 19:15:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/186e41912ca83cb820a2ebf4521457bbfc30d542
Cr-Commit-Position: refs/heads/master@{#385828}

Powered by Google App Engine
This is Rietveld 408576698