Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1869823002: Don't try to dllexport an enum (Closed)

Created:
4 years, 8 months ago by hans
Modified:
4 years, 8 months ago
Reviewers:
Nina
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, mlamouri+watch-notifications_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to dllexport an enum Fixes the following clang warning: ..\..\content/public/common/platform_notification_data.h(21,6): error: 'dllexport' attribute only applies to variables, functions and classes [-Werror,-Wignored-attributes] enum CONTENT_EXPORT PlatformNotificationActionType { ^ ..\..\content/common/content_export.h(12,35): note: expanded from macro 'CONTENT_EXPORT' ^ BUG=82385 TBR=nsatragno Committed: https://crrev.com/55ee909f86bc7b5ec979b062c0024adab7168d43 Cr-Commit-Position: refs/heads/master@{#385805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/platform_notification_data.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869823002/1
4 years, 8 months ago (2016-04-07 16:49:52 UTC) #4
Nina
My bad, thanks for fixing it. lgtm
4 years, 8 months ago (2016-04-07 16:54:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 17:57:02 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 17:58:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55ee909f86bc7b5ec979b062c0024adab7168d43
Cr-Commit-Position: refs/heads/master@{#385805}

Powered by Google App Engine
This is Rietveld 408576698