Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc

Issue 1869793002: Ozone GBM: support R_8 format to GpuMemoryBuffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolve nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_image_ozone_native_pixmap.cc ('k') | ui/ozone/platform/drm/common/drm_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc
diff --git a/ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc b/ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc
index 3e32b7ff1321ace84b3093655ecb6279905641de..ce5c85bac200b446973c421268199e7011670ffc 100644
--- a/ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc
+++ b/ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc
@@ -49,7 +49,13 @@ class ClientNativePixmapFactoryGbm : public ClientNativePixmapFactory {
case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE:
case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT: {
#if defined(OS_CHROMEOS)
- return format == gfx::BufferFormat::BGRA_8888;
+ return
+#if defined(ARCH_CPU_X86_FAMILY)
+ // Currently only i915 in the driver (i.e. minigbm and Mesa)
+ // supports R_8. crbug.com/356871
+ format == gfx::BufferFormat::R_8 ||
dshwang 2016/05/04 07:28:36 narrow R_8 support to only Intel architecture, bec
Daniele Castagna 2016/05/04 19:44:02 Is it true that if the processor architecture is X
dshwang 2016/05/05 07:09:09 Yes, All Intel architecture uses i915 in minigbm.
+#endif
+ format == gfx::BufferFormat::BGRA_8888;
#else
return false;
#endif
« no previous file with comments | « ui/gl/gl_image_ozone_native_pixmap.cc ('k') | ui/ozone/platform/drm/common/drm_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698