Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: blimp/engine/session/blimp_engine_session.cc

Issue 1869783005: [Blimp Client] Fixes up URL before sending it to Engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/feature/navigation_feature_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/session/blimp_engine_session.cc
diff --git a/blimp/engine/session/blimp_engine_session.cc b/blimp/engine/session/blimp_engine_session.cc
index 32cfcd52bdb11113fa5b4913800b6e4e1a77d5aa..4babcbc6827d99be9c26c81f36320ac536087583 100644
--- a/blimp/engine/session/blimp_engine_session.cc
+++ b/blimp/engine/session/blimp_engine_session.cc
@@ -321,7 +321,8 @@ void BlimpEngineSession::HandleResize(float device_pixel_ratio,
void BlimpEngineSession::LoadUrl(const int target_tab_id, const GURL& url) {
DVLOG(1) << "Load URL " << url << " in tab " << target_tab_id;
- if (url.is_empty()) {
+ if (!url.is_valid()) {
+ VLOG(1) << "Dropping invalid URL " << url;
return;
}
« no previous file with comments | « blimp/client/feature/navigation_feature_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698