Move shadowCascadeOrder to Document from StyleEngine

Move shadowCascadeOrder to Document from StyleEngine

This CL moves shadowCascadeOrder function from StyleEngine to Document, so that the function can be called more universally without including StyleEngine header.
The change also makes sense because the shadowCascadingOrder is defined per document, not per styleengine.
See the ShadowDOM Cascade Order discussion here: https://github.com/w3c/webcomponents/issues/316

BUG=601716
Committed: https://crrev.com/7a4cc8d341b50e4f51c73ec408f038940f38c6b0
Cr-Commit-Position: refs/heads/master@{#386329}

[yuzuchan, 2016-04-11 01:32:54]

yuzus@chromium.org changed reviewers:
+ hayato@chromium.org, kochi@chromium.org

[yuzuchan, 2016-04-11 01:32:54]

PTAL :)

[hayato, 2016-04-11 01:49:05]

LGTM

https://codereview.chromium.org/1869773004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1869773004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:5967: ASSERT(order !=
ShadowCascadeOrder::ShadowCascadeNone);
DCHECK_NE(order, ShadowCascadeOrder::ShadowCascadeNone) is recommended.
Source/core/dom is no longer using ASSERT.

[yuzuchan, 2016-04-11 02:06:02]

The CQ bit was checked by yuzus@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-11 02:06:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869773004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869773004/40001

[yuzuchan, 2016-04-11 02:06:33]

https://codereview.chromium.org/1869773004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1869773004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:5967: ASSERT(order !=
ShadowCascadeOrder::ShadowCascadeNone);
On 2016/04/11 at 01:49:05, hayato wrote:
> DCHECK_NE(order, ShadowCascadeOrder::ShadowCascadeNone) is recommended.
> Source/core/dom is no longer using ASSERT.

Done.

[commit-bot: I haz the power, 2016-04-11 03:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 03:33:03]

Dry run: This issue passed the CQ dry run.

[yuzuchan, 2016-04-11 03:36:24]

The CQ bit was checked by yuzus@chromium.org

[yuzuchan, 2016-04-11 03:36:24]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1869773004/#ps40001
(title: "Remove ASSERT and insert DCHECK_NE")

[commit-bot: I haz the power, 2016-04-11 03:36:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869773004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869773004/40001

[commit-bot: I haz the power, 2016-04-11 03:42:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-11 03:43:21]

Description was changed from

==========
Move shadowCascadeOrder to Document from StyleEngine

This CL moves shadowCascadeOrder function from StyleEngine to Document, so that
the function can be called more universally without including StyleEngine
header.
The change also makes sense because the shadowCascadingOrder is defined per
document, not per styleengine.
See the ShadowDOM Cascade Order discussion here:
https://github.com/w3c/webcomponents/issues/316

BUG=601716
==========

to

==========
Move shadowCascadeOrder to Document from StyleEngine

This CL moves shadowCascadeOrder function from StyleEngine to Document, so that
the function can be called more universally without including StyleEngine
header.
The change also makes sense because the shadowCascadingOrder is defined per
document, not per styleengine.
See the ShadowDOM Cascade Order discussion here:
https://github.com/w3c/webcomponents/issues/316

BUG=601716

Committed: https://crrev.com/7a4cc8d341b50e4f51c73ec408f038940f38c6b0
Cr-Commit-Position: refs/heads/master@{#386329}
==========

[commit-bot: I haz the power, 2016-04-11 03:43:22]

Patchset 3 (id:??) landed as
https://crrev.com/7a4cc8d341b50e4f51c73ec408f038940f38c6b0
Cr-Commit-Position: refs/heads/master@{#386329}