content/common/cc_messages_unittest.cc - Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/cc_messages_unittest.cc

Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fmalita review - deconstify sk_sp<>s Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/cc_messages_unittest.cc

diff --git a/content/common/cc_messages_unittest.cc b/content/common/cc_messages_unittest.cc

index c9c45d25960170e55424cf9c0adc6082d6284a94..c42a6d7467f8c02dac8fa8724b647b3b7ef54f07 100644

--- a/content/common/cc_messages_unittest.cc

+++ b/content/common/cc_messages_unittest.cc

@@ -282,10 +282,9 @@ TEST_F(CCMessagesTest, AllQuads) {

FilterOperations arbitrary_filters1;

arbitrary_filters1.Append(FilterOperation::CreateGrayscaleFilter(

arbitrary_float1));

- skia::RefPtr<SkImageFilter> arbitrary_filter = skia::AdoptRef(

- SkBlurImageFilter::Create(arbitrary_sigma, arbitrary_sigma));

arbitrary_filters1.Append(

- cc::FilterOperation::CreateReferenceFilter(arbitrary_filter));

+ cc::FilterOperation::CreateReferenceFilter(

+ SkBlurImageFilter::Make(arbitrary_sigma, arbitrary_sigma, nullptr)));

FilterOperations arbitrary_filters2;

arbitrary_filters2.Append(FilterOperation::CreateBrightnessFilter(