cc/playback/discardable_image_map.cc - Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/playback/discardable_image_map.cc

Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fmalita review - deconstify sk_sp<>s Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/playback/discardable_image_map.cc

diff --git a/cc/playback/discardable_image_map.cc b/cc/playback/discardable_image_map.cc

index 5588a69cc89d329ac733756dc82f4021f52ec901..6fc676a03176e473a426ddd242636a3c1487408b 100644

--- a/cc/playback/discardable_image_map.cc

+++ b/cc/playback/discardable_image_map.cc

@@ -160,11 +160,11 @@ DiscardableImageMap::DiscardableImageMap() {}

DiscardableImageMap::~DiscardableImageMap() {}

-skia::RefPtr<SkCanvas> DiscardableImageMap::BeginGeneratingMetadata(

+sk_sp<SkCanvas> DiscardableImageMap::BeginGeneratingMetadata(

const gfx::Size& bounds) {

DCHECK(all_images_.empty());

- return skia::AdoptRef(new DiscardableImagesMetadataCanvas(

- bounds.width(), bounds.height(), &all_images_));

+ return sk_make_sp<DiscardableImagesMetadataCanvas>(

+ bounds.width(), bounds.height(), &all_images_);

}

void DiscardableImageMap::EndGeneratingMetadata() {