Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: content/common/cc_messages.cc

Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/cc_messages.cc
diff --git a/content/common/cc_messages.cc b/content/common/cc_messages.cc
index 27e01e2312d9e551474c3128dc2f2bb08964c60a..1fc84f34eac3902f2676c6224a9069bd03241d6f 100644
--- a/content/common/cc_messages.cc
+++ b/content/common/cc_messages.cc
@@ -16,6 +16,8 @@
#include "content/public/common/common_param_traits.h"
#include "third_party/skia/include/core/SkData.h"
#include "third_party/skia/include/core/SkFlattenableSerialization.h"
+#include "third_party/skia/include/core/SkImageFilter.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
namespace IPC {
@@ -121,7 +123,7 @@ bool ParamTraits<cc::FilterOperation>::Read(const base::Pickle* m,
}
break;
case cc::FilterOperation::REFERENCE: {
- skia::RefPtr<SkImageFilter> filter;
+ sk_sp<SkImageFilter> filter;
if (!ReadParam(m, iter, &filter)) {
success = false;
break;
@@ -219,8 +221,8 @@ void ParamTraits<cc::FilterOperations>::Log(
l->append(")");
}
-void ParamTraits<skia::RefPtr<SkImageFilter>>::Write(base::Pickle* m,
- const param_type& p) {
+void ParamTraits<sk_sp<SkImageFilter>>::Write(base::Pickle* m,
+ const param_type& p) {
SkImageFilter* filter = p.get();
if (filter) {
sk_sp<SkData> data(SkValidatingSerializeFlattenable(filter));
@@ -230,9 +232,9 @@ void ParamTraits<skia::RefPtr<SkImageFilter>>::Write(base::Pickle* m,
}
}
-bool ParamTraits<skia::RefPtr<SkImageFilter>>::Read(const base::Pickle* m,
- base::PickleIterator* iter,
- param_type* r) {
+bool ParamTraits<sk_sp<SkImageFilter>>::Read(const base::Pickle* m,
+ base::PickleIterator* iter,
+ param_type* r) {
const char* data = 0;
int length = 0;
if (!iter->ReadData(&data, &length))
@@ -240,14 +242,14 @@ bool ParamTraits<skia::RefPtr<SkImageFilter>>::Read(const base::Pickle* m,
if (length > 0) {
SkFlattenable* flattenable = SkValidatingDeserializeFlattenable(
data, length, SkImageFilter::GetFlattenableType());
- *r = skia::AdoptRef(static_cast<SkImageFilter*>(flattenable));
+ *r = sk_sp<SkImageFilter>(static_cast<SkImageFilter*>(flattenable));
} else {
- r->clear();
+ r->reset();
}
return true;
}
-void ParamTraits<skia::RefPtr<SkImageFilter> >::Log(
+void ParamTraits<sk_sp<SkImageFilter> >::Log(
const param_type& p, std::string* l) {
l->append("(");
LogParam(p.get() ? p->countInputs() : 0, l);

Powered by Google App Engine
This is Rietveld 408576698