Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4515)

Unified Diff: cc/tiles/gpu_image_decode_controller.cc

Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/tiles/gpu_image_decode_controller.cc
diff --git a/cc/tiles/gpu_image_decode_controller.cc b/cc/tiles/gpu_image_decode_controller.cc
index 91f0a33ed78f15ca110375ecea76d8f8a308d6ae..e324127b4d406cf62c0303dae0f74643bbd192d5 100644
--- a/cc/tiles/gpu_image_decode_controller.cc
+++ b/cc/tiles/gpu_image_decode_controller.cc
@@ -15,7 +15,6 @@
#include "gpu/command_buffer/client/context_support.h"
#include "gpu/command_buffer/client/gles2_interface.h"
#include "gpu_image_decode_controller.h"
-#include "skia/ext/refptr.h"
#include "skia/ext/texture_handle.h"
#include "third_party/skia/include/core/SkCanvas.h"
#include "third_party/skia/include/core/SkSurface.h"
@@ -64,7 +63,7 @@ class ImageDecodeTaskImpl : public ImageDecodeTask {
uint64_t source_prepare_tiles_id)
: controller_(controller),
image_(draw_image),
- image_ref_(skia::SharePtr(draw_image.image())),
+ image_ref_(sk_ref_sp(draw_image.image())),
danakj 2016/04/14 19:37:33 make image() return sk_sp
tomhudson 2016/04/25 20:48:15 Done in another not-quite-epic-but-largish CL.
source_prepare_tiles_id_(source_prepare_tiles_id) {
DCHECK(!SkipImage(draw_image));
}
@@ -88,7 +87,7 @@ class ImageDecodeTaskImpl : public ImageDecodeTask {
private:
GpuImageDecodeController* controller_;
DrawImage image_;
- skia::RefPtr<const SkImage> image_ref_;
+ sk_sp<const SkImage> image_ref_;
const uint64_t source_prepare_tiles_id_;
DISALLOW_COPY_AND_ASSIGN(ImageDecodeTaskImpl);
@@ -106,7 +105,7 @@ class ImageUploadTaskImpl : public ImageDecodeTask {
: ImageDecodeTask(std::move(decode_dependency)),
controller_(controller),
image_(draw_image),
- image_ref_(skia::SharePtr(draw_image.image())),
+ image_ref_(sk_ref_sp(draw_image.image())),
source_prepare_tiles_id_(source_prepare_tiles_id) {
DCHECK(!SkipImage(draw_image));
}
@@ -132,7 +131,7 @@ class ImageUploadTaskImpl : public ImageDecodeTask {
private:
GpuImageDecodeController* controller_;
DrawImage image_;
- skia::RefPtr<const SkImage> image_ref_;
+ sk_sp<const SkImage> image_ref_;
uint64_t source_prepare_tiles_id_;
DISALLOW_COPY_AND_ASSIGN(ImageUploadTaskImpl);
@@ -158,8 +157,7 @@ GpuImageDecodeController::GpuImageDecodeController(ContextProvider* context,
ResourceFormat decode_format)
: format_(decode_format),
context_(context),
- context_threadsafe_proxy_(
- skia::AdoptRef(context->GrContext()->threadSafeProxy())),
+ context_threadsafe_proxy_(context->GrContext()->threadSafeProxy()),
image_data_(ImageDataMRUCache::NO_AUTO_EVICT),
cached_items_limit_(kMaxDiscardableItems),
cached_bytes_limit_(kMaxGpuImageBytes),
@@ -676,22 +674,22 @@ void GpuImageDecodeController::UploadImageIfNecessary(
// cleaned up so we don't exceed our memory limit during this upload.
DeletePendingImages();
- skia::RefPtr<SkImage> uploaded_image;
+ sk_sp<SkImage> uploaded_image;
{
base::AutoUnlock unlock(lock_);
switch (image_data->mode) {
case DecodedDataMode::CPU: {
SkImageInfo image_info = CreateImageInfoForDrawImage(draw_image);
- uploaded_image = skia::AdoptRef(SkImage::NewFromRaster(
- image_info, image_data->decode.data->data(),
- image_info.minRowBytes(), [](const void*, void*) {}, nullptr));
+ SkPixmap p(image_info, image_data->decode.data->data(),
+ image_info.minRowBytes());
+ uploaded_image =
+ SkImage::MakeFromRaster(p, [](const void*, void*) {}, nullptr);
break;
}
case DecodedDataMode::GPU: {
- uploaded_image =
- skia::AdoptRef(SkImage::NewFromDeferredTextureImageData(
- context_->GrContext(), image_data->decode.data->data(),
- SkBudgeted::kNo));
+ uploaded_image = SkImage::MakeFromDeferredTextureImageData(
+ context_->GrContext(), image_data->decode.data->data(),
+ SkBudgeted::kNo);
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698