cc/output/gl_renderer_unittest.cc - Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/gl_renderer_unittest.cc

diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc

index 641b4587f70a82aaa78ae9c6acc5e6aeff282b56..2cafb3c5e579cd6f38fcd70199c80e73521634ff 100644

--- a/cc/output/gl_renderer_unittest.cc

+++ b/cc/output/gl_renderer_unittest.cc

@@ -1433,7 +1433,7 @@ TEST_F(GLRendererShaderTest, DrawRenderPassQuadShaderPermutations) {

matrix[18] = 1;

sk_sp<SkColorFilter> color_filter =

SkColorFilter::MakeMatrixFilterRowMajor255(matrix);

- skia::RefPtr<SkImageFilter> filter = skia::AdoptRef(

+ sk_sp<SkImageFilter> filter(

SkColorFilterImageFilter::Create(color_filter.get(), NULL));

FilterOperations filters;

filters.Append(FilterOperation::CreateReferenceFilter(filter));

danakj 2016/04/14 19:37:31 can move the |filter| here

tomhudson 2016/04/25 20:48:11 inlined instead.