Replace many skia::RefPtr with sk_sp<> in cc/

skia/ext/platform_canvas.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SKIA_EXT_PLATFORM_CANVAS_H_
 #define SKIA_EXT_PLATFORM_CANVAS_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 71 matching lines @@
                                         uint8_t* data,
                                         OnFailureType failure_type);
 #endif
 
 static inline SkCanvas* CreatePlatformCanvas(int width,
                                              int height,
                                              bool is_opaque) {
   return CreatePlatformCanvas(width, height, is_opaque, 0, CRASH_ON_FAILURE);
 }
 
-SK_API SkCanvas* CreateCanvas(const sk_sp<SkBaseDevice>& device,
+SK_API SkCanvas* CreateCanvas(sk_sp<SkBaseDevice>& device,

[f(malita), 2016/04/21 15:45:47]

const sk_sp<SkBaseDevice>&

(
We normally use either const sk_sp<>& or sk_sp<>.  In this case the former looks
like a better fit because all we use is its raw value.

If SkCanvas ever grows a sk_sp<SkDevice> ctor, we can switch to the latter.
)

[danakj, 2016/04/21 23:37:21]

If you're not going to ref the thing, take a T* instead of a const sk_sp<T>&.

[tomhudson, 2016/04/25 20:20:51]

Done.

                               OnFailureType failure_type);
 
 static inline SkCanvas* CreateBitmapCanvas(int width,
                                            int height,
                                            bool is_opaque) {
   return CreatePlatformCanvas(width, height, is_opaque, 0, CRASH_ON_FAILURE);
 }
 
 static inline SkCanvas* TryCreateBitmapCanvas(int width,
                                               int height,
@@ skipping 69 matching lines @@
 SK_API bool IsPreviewMetafile(const SkCanvas& canvas);
 
 // Returns the CGContext that backing the SkCanvas.
 // Returns NULL if none is bound.
 SK_API CGContextRef GetBitmapContext(const SkCanvas& canvas);
 #endif
 
 }  // namespace skia
 
 #endif  // SKIA_EXT_PLATFORM_CANVAS_H_