Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Side by Side Diff: cc/playback/recording_source_unittest.cc

Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fmalita review - deconstify sk_sp<>s Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "cc/base/region.h" 8 #include "cc/base/region.h"
9 #include "cc/playback/raster_source.h" 9 #include "cc/playback/raster_source.h"
10 #include "cc/proto/recording_source.pb.h" 10 #include "cc/proto/recording_source.pb.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 ValidateRecordingSourceSerialization(recording_source.get()); 95 ValidateRecordingSourceSerialization(recording_source.get());
96 } 96 }
97 97
98 TEST(RecordingSourceTest, DiscardableImagesWithTransform) { 98 TEST(RecordingSourceTest, DiscardableImagesWithTransform) {
99 gfx::Rect recorded_viewport(256, 256); 99 gfx::Rect recorded_viewport(256, 256);
100 100
101 std::unique_ptr<FakeRecordingSource> recording_source = 101 std::unique_ptr<FakeRecordingSource> recording_source =
102 FakeRecordingSource::CreateFilledRecordingSource( 102 FakeRecordingSource::CreateFilledRecordingSource(
103 recorded_viewport.size()); 103 recorded_viewport.size());
104 skia::RefPtr<SkImage> discardable_image[2][2]; 104 sk_sp<SkImage> discardable_image[2][2];
105 gfx::Transform identity_transform; 105 gfx::Transform identity_transform;
106 discardable_image[0][0] = CreateDiscardableImage(gfx::Size(32, 32)); 106 discardable_image[0][0] = CreateDiscardableImage(gfx::Size(32, 32));
107 // Translate transform is equivalent to moving using point. 107 // Translate transform is equivalent to moving using point.
108 gfx::Transform translate_transform; 108 gfx::Transform translate_transform;
109 translate_transform.Translate(0, 130); 109 translate_transform.Translate(0, 130);
110 discardable_image[1][0] = CreateDiscardableImage(gfx::Size(32, 32)); 110 discardable_image[1][0] = CreateDiscardableImage(gfx::Size(32, 32));
111 // This moves the bitmap to center of viewport and rotate, this would make 111 // This moves the bitmap to center of viewport and rotate, this would make
112 // this bitmap in all four tile grids. 112 // this bitmap in all four tile grids.
113 gfx::Transform rotate_transform; 113 gfx::Transform rotate_transform;
114 rotate_transform.Translate(112, 112); 114 rotate_transform.Translate(112, 112);
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 245
246 std::unique_ptr<FakeRecordingSource> recording_source = 246 std::unique_ptr<FakeRecordingSource> recording_source =
247 CreateRecordingSource(recorded_viewport); 247 CreateRecordingSource(recorded_viewport);
248 248
249 SkPaint simple_paint; 249 SkPaint simple_paint;
250 simple_paint.setColor(SkColorSetARGB(255, 12, 23, 34)); 250 simple_paint.setColor(SkColorSetARGB(255, 12, 23, 34));
251 251
252 SkBitmap non_discardable_bitmap; 252 SkBitmap non_discardable_bitmap;
253 non_discardable_bitmap.allocN32Pixels(128, 128); 253 non_discardable_bitmap.allocN32Pixels(128, 128);
254 non_discardable_bitmap.setImmutable(); 254 non_discardable_bitmap.setImmutable();
255 skia::RefPtr<SkImage> non_discardable_image = 255 sk_sp<SkImage> non_discardable_image =
256 skia::AdoptRef(SkImage::NewFromBitmap(non_discardable_bitmap)); 256 SkImage::MakeFromBitmap(non_discardable_bitmap);
257 257
258 recording_source->add_draw_rect_with_paint(gfx::Rect(0, 0, 256, 256), 258 recording_source->add_draw_rect_with_paint(gfx::Rect(0, 0, 256, 256),
259 simple_paint); 259 simple_paint);
260 recording_source->add_draw_rect_with_paint(gfx::Rect(128, 128, 512, 512), 260 recording_source->add_draw_rect_with_paint(gfx::Rect(128, 128, 512, 512),
261 simple_paint); 261 simple_paint);
262 recording_source->add_draw_rect_with_paint(gfx::Rect(512, 0, 256, 256), 262 recording_source->add_draw_rect_with_paint(gfx::Rect(512, 0, 256, 256),
263 simple_paint); 263 simple_paint);
264 recording_source->add_draw_rect_with_paint(gfx::Rect(0, 512, 256, 256), 264 recording_source->add_draw_rect_with_paint(gfx::Rect(0, 512, 256, 256),
265 simple_paint); 265 simple_paint);
266 recording_source->add_draw_image(non_discardable_image.get(), 266 recording_source->add_draw_image(non_discardable_image.get(),
(...skipping 30 matching lines...) Expand all
297 EXPECT_TRUE(images.empty()); 297 EXPECT_TRUE(images.empty());
298 } 298 }
299 } 299 }
300 300
301 TEST(RecordingSourceTest, DiscardableImages) { 301 TEST(RecordingSourceTest, DiscardableImages) {
302 gfx::Rect recorded_viewport(0, 0, 256, 256); 302 gfx::Rect recorded_viewport(0, 0, 256, 256);
303 303
304 std::unique_ptr<FakeRecordingSource> recording_source = 304 std::unique_ptr<FakeRecordingSource> recording_source =
305 CreateRecordingSource(recorded_viewport); 305 CreateRecordingSource(recorded_viewport);
306 306
307 skia::RefPtr<SkImage> discardable_image[2][2]; 307 sk_sp<SkImage> discardable_image[2][2];
308 discardable_image[0][0] = CreateDiscardableImage(gfx::Size(32, 32)); 308 discardable_image[0][0] = CreateDiscardableImage(gfx::Size(32, 32));
309 discardable_image[1][0] = CreateDiscardableImage(gfx::Size(32, 32)); 309 discardable_image[1][0] = CreateDiscardableImage(gfx::Size(32, 32));
310 discardable_image[1][1] = CreateDiscardableImage(gfx::Size(32, 32)); 310 discardable_image[1][1] = CreateDiscardableImage(gfx::Size(32, 32));
311 311
312 // Discardable images are found in the following cells: 312 // Discardable images are found in the following cells:
313 // |---|---| 313 // |---|---|
314 // | x | | 314 // | x | |
315 // |---|---| 315 // |---|---|
316 // | x | x | 316 // | x | x |
317 // |---|---| 317 // |---|---|
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 367
368 TEST(RecordingSourceTest, DiscardableImagesBaseNonDiscardable) { 368 TEST(RecordingSourceTest, DiscardableImagesBaseNonDiscardable) {
369 gfx::Rect recorded_viewport(0, 0, 512, 512); 369 gfx::Rect recorded_viewport(0, 0, 512, 512);
370 370
371 std::unique_ptr<FakeRecordingSource> recording_source = 371 std::unique_ptr<FakeRecordingSource> recording_source =
372 CreateRecordingSource(recorded_viewport); 372 CreateRecordingSource(recorded_viewport);
373 373
374 SkBitmap non_discardable_bitmap; 374 SkBitmap non_discardable_bitmap;
375 non_discardable_bitmap.allocN32Pixels(512, 512); 375 non_discardable_bitmap.allocN32Pixels(512, 512);
376 non_discardable_bitmap.setImmutable(); 376 non_discardable_bitmap.setImmutable();
377 skia::RefPtr<SkImage> non_discardable_image = 377 sk_sp<SkImage> non_discardable_image =
378 skia::AdoptRef(SkImage::NewFromBitmap(non_discardable_bitmap)); 378 SkImage::MakeFromBitmap(non_discardable_bitmap);
379 379
380 skia::RefPtr<SkImage> discardable_image[2][2]; 380 sk_sp<SkImage> discardable_image[2][2];
381 discardable_image[0][0] = CreateDiscardableImage(gfx::Size(128, 128)); 381 discardable_image[0][0] = CreateDiscardableImage(gfx::Size(128, 128));
382 discardable_image[0][1] = CreateDiscardableImage(gfx::Size(128, 128)); 382 discardable_image[0][1] = CreateDiscardableImage(gfx::Size(128, 128));
383 discardable_image[1][1] = CreateDiscardableImage(gfx::Size(128, 128)); 383 discardable_image[1][1] = CreateDiscardableImage(gfx::Size(128, 128));
384 384
385 // One large non-discardable image covers the whole grid. 385 // One large non-discardable image covers the whole grid.
386 // Discardable images are found in the following cells: 386 // Discardable images are found in the following cells:
387 // |---|---| 387 // |---|---|
388 // | x | x | 388 // | x | x |
389 // |---|---| 389 // |---|---|
390 // | | x | 390 // | | x |
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 &images); 433 &images);
434 EXPECT_EQ(3u, images.size()); 434 EXPECT_EQ(3u, images.size());
435 EXPECT_TRUE(images[0].image() == discardable_image[0][0].get()); 435 EXPECT_TRUE(images[0].image() == discardable_image[0][0].get());
436 EXPECT_TRUE(images[1].image() == discardable_image[0][1].get()); 436 EXPECT_TRUE(images[1].image() == discardable_image[0][1].get());
437 EXPECT_TRUE(images[2].image() == discardable_image[1][1].get()); 437 EXPECT_TRUE(images[2].image() == discardable_image[1][1].get());
438 } 438 }
439 } 439 }
440 440
441 } // namespace 441 } // namespace
442 } // namespace cc 442 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698