Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1869733003: Add canary and dev channels to the chrome_binaries config. (Closed)

Created:
4 years, 8 months ago by aiolos (Not reviewing)
Modified:
4 years, 8 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add canary and dev channels to the chrome_binaries config. This will allow us to use the dependency manager to find chrome binaries for both those channels. Also update the stable channel. BUG=catapult:#2227

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -16 lines) Patch
M catapult_base/catapult_base/chrome_binaries.json View 2 chunks +114 lines, -16 lines 1 comment Download

Messages

Total messages: 9 (5 generated)
aiolos (Not reviewing)
https://codereview.chromium.org/1869733003/diff/1/catapult_base/catapult_base/chrome_binaries.json File catapult_base/catapult_base/chrome_binaries.json (right): https://codereview.chromium.org/1869733003/diff/1/catapult_base/catapult_base/chrome_binaries.json#newcode128 catapult_base/catapult_base/chrome_binaries.json:128: "reference_build": { This should get deleted when telemetry moves ...
4 years, 8 months ago (2016-04-07 21:16:03 UTC) #3
nednguyen
lgtm Just "git cl land" this after you run ./telemetry/validate_binary_dependencies on the file.
4 years, 8 months ago (2016-04-07 22:05:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869733003/1
4 years, 8 months ago (2016-04-07 22:58:54 UTC) #8
aiolos (Not reviewing)
4 years, 8 months ago (2016-04-08 00:21:26 UTC) #9
This was git cl landed, not sure why it didn't close the bug.

I've verified that the change is in the build. Closing.

Powered by Google App Engine
This is Rietveld 408576698