Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1869733002: Initialize TextInputState::TextInputState::show_ime_if_needed in the constructor. (Closed)

Created:
4 years, 8 months ago by Alexander Potapenko
Modified:
4 years, 8 months ago
Reviewers:
EhsanK, Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize TextInputState::TextInputState::show_ime_if_needed in the constructor. BUG=601424 TBR=ekaramad@chromium.org,creis@chromium.org Committed: https://crrev.com/0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f Cr-Commit-Position: refs/heads/master@{#385742}

Patch Set 1 #

Patch Set 2 : Fix order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/common/text_input_state.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Alexander Potapenko
TBR
4 years, 8 months ago (2016-04-07 12:27:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869733002/1
4 years, 8 months ago (2016-04-07 12:27:32 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/46825) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-07 12:37:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869733002/20001
4 years, 8 months ago (2016-04-07 12:43:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 13:44:06 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f Cr-Commit-Position: refs/heads/master@{#385742}
4 years, 8 months ago (2016-04-07 13:45:09 UTC) #10
EhsanK
4 years, 8 months ago (2016-04-07 14:32:55 UTC) #11
Message was sent while issue was closed.
On 2016/04/07 13:45:09, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/0c15a6bce78d7dc48bdaac09d90dc8cd55893b6f
> Cr-Commit-Position: refs/heads/master@{#385742}

Thanks for fixing this. LGTM.

Powered by Google App Engine
This is Rietveld 408576698